Query: Fix metadataServer/rulesServer/targetsServer data race #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmiehan <hanjinming@outlook.com>
hanjm
force-pushed
the
fix/jimmiehan-fix-proxy-server-data-race
branch
from
dc2b99a
to
1391b70
Compare
|
Hi @GiedriusS , could you help me review this fixes, Thank you. |
yeya24
approved these changes
Oct 30, 2021
akanshat
pushed a commit
to akanshat/thanos
that referenced
this pull request
Oct 30, 2021
…-io#4811) Signed-off-by: Jimmiehan <hanjinming@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant #4805.
Signed-off-by: Jimmiehan hanjinming@outlook.com
Changes
sync.Mutexto*metadataServer/*rulesServer/*targetsServer.Verification
go test -race -run TestProxyDataRace -v